[x264-devel] Multislicing support

[Etienne Bömcke]

Hi,

I did that modification, but it is still buggy. If you take a look at  
the patch, it changes the function x264_realloc as you recommended it.  
Still, when reallocating the h->out.nal pointer in x264_nal_end, it  
gets corrupted. The nal payload then takes an absurdly high value,  
causing eventually a memory error with x264 trying to allocate more  
than 40Gb of memory in the function Encode_frame, line 759.
I definitely think there's still something wrong with that function.

Regards,

Etienne


On 26 Apr 2008, at 06:38, Mathieu Monnier wrote:

> Hi,
>
>> I found the bug causing the strange behaviour described in these last
>> two items, and the responsible is the function /x264_realloc/. I
>> remember someone telling me the function was buggy, but I thought  
>> it had
>> been corrected since then. I'm afraid I can't help with that, as I
>> barely understand how the function works. There is just one thing I'd
>> like to know : how come the function doesn't call /realloc/, as the  
>> file
>> malloc.h is obviously present on my computer? Isn't the variable
>> HAVE_MALLOC_H defined on any system having the malloc helper file?  
>> This
>> is more a basic C question, but if anybody has an answer it would  
>> help
>> me having an even greater week-end. :-)
>
> You really have a problem with your mailer, I already answered that
> question two months ago, in reply to one of your post :
>
>> x264_realloc is buggy, fixing it would fix the issue :
>>
>> -        i_old_size = *( (int*) ( (uint8_t*) p ) - sizeof( void  
>> ** ) -
>> -                         sizeof( int ) );
>> +        i_old_size = *( (int*) ( (uint8_t*) p - sizeof( void ** ) -
>> +                         sizeof( int ) ) );
>
> Regards,
>
> Mathieu
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel

--
Etienne Bömcke
UCL - Laboratoire TELE
etienne.bomcke at uclouvain.be