[x264-devel] Possible problem in configure script

[Markus Kanet]

Hi...

in commit 9d4d168bb484c2a27e9f4b8f5eb360a00a1cf426 "improve generation 
of Darwin libraries" seem to be a small typo. Here is the intresting 
part of that commit:

+        if [ "$SYS" = "MACOSX" ]; then
+            echo "SOSUFFIX=dylib" >> gtk/config.mak
+            echo "SONAMEGTK=libx264gtk.$API.dylib" >> gtk/config.mak
+            echo 'SOFLAGS=-dynamiclib -Wl,-single_module 
-Wl,-read_only_relocs,suppress -install_name 
$(DESTDIR)$(libdir)/$(SONAMEGTK)' >> gtk/config.mak
+        else
+            echo "SOSUFFIX=so" >> gtk/config.mak
+            echo "SONAMEGTK=libx264gtk.so.$API" >> gtk/config.mak
+            echo 'SOFLAGS=-Wl,-soname,$(SONAME)' >> gtk/config.mak
+        fi

When the system is not MACOSX then the SOFLAGS for GTK are defined as:
   echo 'SOFLAGS=-Wl,-soname,$(SONAME)' >> gtk/config.mak

While i'm sure it should be
   echo 'SOFLAGS=-Wl,-soname,$(SONAMEGTK)' >> gtk/config.mak

Attached is a patch to correct SOFLAGS for GTK.

Markus


-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-buildfix.patch
Type: text/x-patch
Size: 576 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20080825/9ac1b560/attachment.bin