[x264-devel] NOTE: Altivec/PPC port is broken [PATCH]

[Guillaume POIRIER]

Hello,

2008/3/20 <maaanuuu at gmx.net>:
> Here is a patch that fixes the scan4x4 altivec routines.

Thanks. That indeed fixes it. Patch applied (not by me, I don't know
who may that be).


> The checkasm
> tests pass after applying this patch.

Not on my test Linux/PPC64 machine, as well as on my OSX/PPC:

./tools/checkasm
x264: using random seed 3208205452
x264: ALTIVEC against C
 - pixel sad :           [OK]
 - pixel ssd :           [OK]
 - pixel satd :          [OK]
 - pixel sa8d :          [OK]
 - pixel sad_x3 :        [OK]
 - pixel sad_x4 :        [OK]
 - sub_dct4 :            [OK]
 - sub_dct8 :            [OK]
 - add_idct4 :           [OK]
 - add_idct8 :           [OK]
 - zigzag_frame :        [OK]
 - zigzag_field :        [OK]
 - mc luma :             [OK]
 - mc chroma :           [OK]
hpel filter differs at plane c line 0
87ae3ba0 ff817eb3 88a2814d 2a4b4b56 b06f0095 6a397f31 12a29c40
667c9353 a56950a1 55949e25 cbe68040 3a683c98
8bad3ba0 ff817eb3 88a2814d 2a4b4b56 b06f0095 6a397f31 12a29c40
667c9353 a56950a1 55949e25 cbe68040 3a674375
 - hpel filter :         [FAILED]
 - intra pred :          [OK]
 - deblock :             [OK]
 - quant :               [OK]
 - dequant :             [OK]
x264: at least one test has failed. Go and fix that Right Now!


Can you confirm this?

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte