[x264-devel] Missing SFENCE after MOVNTQ?

[Zuxy Meng]

Hi,

2008/3/31, Loren Merritt <lorenm at u.washington.edu>:
> On Sun, 30 Mar 2008, Zuxy Meng wrote:
>
> > I see movntq is used in x264_hpel_filter_mmxext() and
> > x264_plane_copy_mmxext() w/o an accompanying sfence. Is it a mistake
> > or intentional?
>
> Mistake. I was unaware of the requirement, and it never broke for me.

Normally it won't, unless you're using multicore and a bit unlucky.
Anyway, here's a patch.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sfence.diff
Url: http://mailman.videolan.org/pipermail/x264-devel/attachments/20080331/6f2bdaf7/attachment.txt