[x264-devel] [PATCH] x264 executable stack and selinux

[Guillaume POIRIER]

Hello,

2007/9/30 Dominik 'Rathann' Mierzejewski <dominik at greysector.net>:
> Hello.
>  One of the users reported a problem with SELinux:
>  http://bugzilla.livna.org/show_bug.cgi?id=1659
>
>  Starting totem on i386 gives:
>  (totem:670): GStreamer-WARNING **: Failed to load plugin
>  '/usr/lib/gstreamer-0.10/libgstx264.so': libx264.so.56: cannot enable executable
>  stack as shared object requires: Permission denied
>
>  This is caused by a difference in yasm and nasm syntax [...]
>
>  Patch attached.

This patch doesn't apply since Loren factorized the AMD64 and x86
code. Attached is a newer version that applies cleanly.


However, I'm tempted to reject that patch since for some time already,
only YASM support has been supported, so having binaries built with
NASM that cause some trouble is to be expected.


Maybe a cleared statement or a configure test should be added to
require YASM, but I doubt that it will please people, since IIRC,
simple cases such as static lib on Linux and Windows x86 (that is, a
large majority of x264's userbase) should work, thought it's mainly by
luck.


I'd prefer if Loren could take a decision about the problem of NASM's support.

Guillaume
-- 
I don't measure a man's success by how high he climbs but how high he
bounces when he hits bottom.
 -- George S. Patton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: noexec_stack.2.diff
Type: application/octet-stream
Size: 568 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20080512/e0ce4782/attachment.obj