[x264-devel] [PATCH] OS/2 support + '--with-install' option

[KO Myung-Hun]

Hi/2.

Is this patch rejected ?

If so, why ?

KO Myung-Hun wrote:
> Hi/2.
>
> Loren Merritt wrote:
>> On Sun, 28 Sep 2008, KO Myung-Hun wrote:
>>  
>>> Loren Merritt wrote:
>>>    
>>>> On Sat, 27 Sep 2008, KO Myung-Hun wrote:
>>>>
>>>>      
>>>>> + ; Kludge: aout format does not support .rodata neither align, so 
>>>>> use .data.
>>>>>         
>>>> Then you can't use SSE. Unless you mean that all sections are 
>>>> always 16-byte aligned, and only the attribute is missing?
>>>>       
>>> Does it mean crash or disablement of SSE feature ?
>>>     
>>
>> Crash, since x264 has no way of knowing that your linker failed to 
>> align stuff.
>>
>>   
>
> Ok. I attach some test codes to confirm section alignment.
>
> And I tested them like this.
>
> nasm -f aout seg-a1.asm
> nasm -f aout seg-a2.asm
> nasm -f aout seg-a3.asm
> gcc seg.c seg-a1.o seg-a2.o seg-a3.o
>
> The result from seg.exe is the following.
>
> -----
> test1_data = 0x20050
> test2_data = 0x20060
> test3_data = 0x20070
> test1_bss = 0x20100
> test2_bss = 0x20110
> test3_bss = 0x20120
> test1_text = 0x101a8
> test2_text = 0x101ac
> test3_text = 0x101b0
> -----
>
> I think this means .data and .bss are 16-bytes aligned, and .text is 
> 4-bytes aligned, so kludge for aout is acceptable.
>
> What do you think about this ?
>
>>> Finally, I have a question.
>>>
>>> Is tools/avc2avi.c maintained ?
>>>     
>>
>> No. And since you brought it up, I'll delete avc2avi.
>> avc doesn't belong in avi.
>>
>>   
>
> No problem.
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.12
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr