[x264-devel] commit: Minor fixes and cosmetics (Jason Garrett-Glaser )

git version control git at videolan.org
Wed Feb 11 19:47:28 CET 2009


x264 | branch: master | Jason Garrett-Glaser <darkshikari at gmail.com> | Wed Feb 11 10:35:56 2009 -0800| [d56e13f9016b898a3bd4043b26c2e70c2bb9f6c4] | committer: Jason Garrett-Glaser 

Minor fixes and cosmetics
Suppress a GCC warning, fix a non-problematic array overflow, one REP->REP_RET.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=d56e13f9016b898a3bd4043b26c2e70c2bb9f6c4
---

 common/x86/quant-a.asm |    2 +-
 encoder/cabac.c        |    2 ++
 encoder/encoder.c      |    3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/common/x86/quant-a.asm b/common/x86/quant-a.asm
index fbabd16..419499b 100644
--- a/common/x86/quant-a.asm
+++ b/common/x86/quant-a.asm
@@ -920,7 +920,7 @@ cglobal x264_coeff_level_run%2_%1,0,7
     inc    t6d
     sub    t4d, t3d
     jge .loop
-    RET
+    REP_RET
 %endmacro
 
 INIT_MMX
diff --git a/encoder/cabac.c b/encoder/cabac.c
index 62280c1..f84c1b4 100644
--- a/encoder/cabac.c
+++ b/encoder/cabac.c
@@ -541,6 +541,8 @@ static int ALWAYS_INLINE x264_cabac_mb_cbf_ctxidxinc( x264_t *h, int i_cat, int
             i_nza = h->mb.i_neighbour & MB_LEFT ? (h->mb.cbp[h->mb.i_mb_xy - 1] >> (9 + i_idx)) & 1 : b_intra;
             i_nzb = h->mb.i_neighbour & MB_TOP  ? (h->mb.cbp[h->mb.i_mb_top_xy] >> (9 + i_idx)) & 1 : b_intra;
             return 4*i_cat + 2*i_nzb + i_nza;
+        default:
+            return 0;
     }
 }
 
diff --git a/encoder/encoder.c b/encoder/encoder.c
index 593f780..7f7e280 100644
--- a/encoder/encoder.c
+++ b/encoder/encoder.c
@@ -1734,7 +1734,8 @@ static void x264_encoder_frame_end( x264_t *h, x264_t *thread_current,
     pic_out->i_pts = h->fenc->i_pts;
 
     pic_out->img.i_plane = h->fdec->i_plane;
-    for(i = 0; i < 4; i++){
+    for(i = 0; i < 3; i++)
+    {
         pic_out->img.i_stride[i] = h->fdec->i_stride[i];
         pic_out->img.plane[i] = h->fdec->plane[i];
     }



More information about the x264-devel mailing list