[x264-devel] commit: Fix C99ism in r1066 (Jason Garrett-Glaser )

Loren Merritt lorenm at u.washington.edu
Fri Jan 2 17:17:30 CET 2009

On Fri, 2 Jan 2009, Guillaume Poirier wrote:
>> x264 | branch: master | Jason Garrett-Glaser <darkshikari at gmail.com>
>> | Thu Jan  1 21:38:33 2009 -0500|
>> [1e2f6d258df09874e2e0c85ef611f27d397555bf] | committer: Jason
>> Garrett-Glaser
>> Fix C99ism in r1066
> BTW, what's the coding guidelines about this? I use C99's mixed code
> with declaration in Altivec code, since all the compilers that are
> supposed to compile this code support C99.
> Are you avoiding C99ism for "cosmetic" reasons or because some
> compiler (I want names!) don't support it?

We were avoiding mixed code with declarations because msvc doesn't support 
it. I history-editted to remove this revision because I'm dropping support 
for msvc.
Feel free to argue with that decision, but know that I don't consider 
"some devs use it and they have no choice" to be a sufficient argument.

--Loren Merritt

More information about the x264-devel mailing list