[x264-devel] Windows x64 support

[BugMaster]

On Tue, 27 Jan 2009 10:44:15 -0500, Steven Walters wrote:
>> Fixed a crash in x264_pixel_avg_weight_*_ssse3 x86_32.
>> The rest of my changes are cosmetic, but you should still check whether they
>> work.

> with both patches applied it causes

> $ ./checkasm.exe
> x264: using random seed 2618250584
> x264: All tests passed Yeah :)

> and

> x264 [error]: your cpu does not support MMXEXT, but x264 was compiled
> with asm support
> x264 [error]: to run x264, recompile without asm support (configure
> --disable-asm)
> x264 [error]: x264_encoder_open failed

> while as BugMaster's patch by itself works fine.
> so Loren's patch is apparently breaking x264_cpu_cpuid

Try this:
http://stashbox.org/377739/x264_win64_support.04.r1090.diff
I fix x264_cpu_cpuid broken by Loren's patch.

On Tue, 27 Jan 2009 12:52:43 +0000 (UTC), Loren Merritt wrote:
> Fixed a crash in x264_pixel_avg_weight_*_ssse3 x86_32.
> The rest of my changes are cosmetic, but you should still check whether
> they work.

> Yes, `yasm -f win32` is the same as -f win64, and this way is more 
> convenient for ffmpeg's configure, I think.

> --Loren Merritt

As I guess crash was due my swap of BIWEIGHT_START and AVG_START. But
I couldn't understand when this will cause crash. Can you at which platform
it crashes and at which instruction.

Anton Mitrofanov (a.k.a. BugMaster)