[x264-devel] Windows x64 support

Loren Merritt lorenm at u.washington.edu
Wed Jan 28 07:34:47 CET 2009


On Tue, 27 Jan 2009, BugMaster wrote:

> As I guess crash was due my swap of BIWEIGHT_START and AVG_START. But
> I couldn't understand when this will cause crash. Can you at which platform
> it crashes and at which instruction.

BIWEIGHT_START_SSSE3 uses some temporary registers (t6,t7). On x86_32, in 
order to avoid unnecessary spilling, these are the same registers as the 
function args are loaded into. So BIWEIGHT_START_SSSE3 has to be before 
PROLOGUE, or the args get clobbered.

> Loren, may be it is better to replace
>     movsxd r2, dword r4m ; FIXME truncates pointer
>     movsxd r3, dword r5m ; FIXME truncates pointer
> in x264_checkasm_call with
>     mov  r2d, r4m ; FIXME truncates pointer
>     mov  r3d, r5m ; FIXME truncates pointer

ok

--Loren Merritt


More information about the x264-devel mailing list