[x264-devel] [patch] control of maximum nalu size (multi-sclicing)

[Jason Garrett-Glaser]

On Sun, Jul 5, 2009 at 10:03 AM, Simon Morlat<simon.morlat at linphone.org> wrote:
> Le dimanche 5 juillet 2009 01:43:02, Marc Schulz a écrit :
>> If you want the feature then write a patch that will conform to the high
>> standards of x264.
> Is there any document explaining the "high standarts of x264" ?
>
>> Then once they are ready to add this feature it will be
>> added.
> Ok, in two years, when the patch no more applies....
>
>> There is absolutely no point in being a child about this. Besides as
>> you stated you already maintain a fork, so this should work for people who
>> absolutely need this feature at the moment.
>
> Other people before me contributed similar patches (with even more features)
> and they haven't been merged. It seems that there will always have good reason
> to reject a patch.
> I don't like forks because it does not make the world simple. I would have
> prefered this small 10-lines-added patch to be integrated.
> We are writting more lines in this mailing list than the patch itself
> contains...
> x264 is a great project. The code is very well written, works very well, very
> stable and runs very fast. Achieving this, for my standpoint, is not
> incompatible with managing the project in a bit more opened way.
>
> Simon

OK, I'll reconsider if I get a patch that does the following:

1.  Implement slicing, with the following two options:
a) Max NALU size.
b) Number of slices per frame.
2.  Works for any number of slices (the previous "good" patch failed
bizarrely with more than 4).
3.  Allows motion vectors across slice boundaries.
4.  Deblocks across slice boundaries.  This is very important.
5.  Is written with the coding standards of x264 in mind (I hope I
don't have to tell you to use spaces instead of tabs, etc).

Dark Shikari