[x264-devel] [patch] control of maximum nalu size (multi-sclicing)

[Etienne Bömcke]

I don't want to brag about my work, but the patch I submitted some  
time ago already had some of the features you mentioned. The max NALU  
size has been implemented by Mojtaba, and the number of slice per  
frame could be easily achieved by modifying the code I added to  
specify the slice size in macroblocks. I'm not sure about whether it  
allows deblocking across slice boundaries though, so I might have to  
check that. Furthermore, my programming experience isn't sufficient  
for me to judge if the code respects the x264 coding standards. If I  
remember correctly, I did use spaces, but that's as far as I can go...
More seriously, If anybody's interested in that topic, I can produce  
an updated patch for the most recent version, and work with him to get  
it merged into x264's main branch.

Regards,

Etienne


On 05 Jul 2009, at 19:35, Jason Garrett-Glaser wrote:

> On Sun, Jul 5, 2009 at 10:03 AM, Simon Morlat<simon.morlat at linphone.org 
> > wrote:
>> Le dimanche 5 juillet 2009 01:43:02, Marc Schulz a écrit :
>>> If you want the feature then write a patch that will conform to  
>>> the high
>>> standards of x264.
>> Is there any document explaining the "high standarts of x264" ?
>>
>>> Then once they are ready to add this feature it will be
>>> added.
>> Ok, in two years, when the patch no more applies....
>>
>>> There is absolutely no point in being a child about this. Besides as
>>> you stated you already maintain a fork, so this should work for  
>>> people who
>>> absolutely need this feature at the moment.
>>
>> Other people before me contributed similar patches (with even more  
>> features)
>> and they haven't been merged. It seems that there will always have  
>> good reason
>> to reject a patch.
>> I don't like forks because it does not make the world simple. I  
>> would have
>> prefered this small 10-lines-added patch to be integrated.
>> We are writting more lines in this mailing list than the patch itself
>> contains...
>> x264 is a great project. The code is very well written, works very  
>> well, very
>> stable and runs very fast. Achieving this, for my standpoint, is not
>> incompatible with managing the project in a bit more opened way.
>>
>> Simon
>
> OK, I'll reconsider if I get a patch that does the following:
>
> 1.  Implement slicing, with the following two options:
> a) Max NALU size.
> b) Number of slices per frame.
> 2.  Works for any number of slices (the previous "good" patch failed
> bizarrely with more than 4).
> 3.  Allows motion vectors across slice boundaries.
> 4.  Deblocks across slice boundaries.  This is very important.
> 5.  Is written with the coding standards of x264 in mind (I hope I
> don't have to tell you to use spaces instead of tabs, etc).
>
> Dark Shikari
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel

--
Etienne Bömcke
Laboratoire de Télécommunications et Télédétections
Université Catholique de Louvain
Bâtiment Stevin - Place du Levant, 2
B-1348 Louvain-la-Neuve

e-mail : etienne.bomcke at uclouvain.be
tel : +32 10 47 85 51