[x264-devel] [Patch][RFC] moving presets, tunings, profiles from x264.c to common.c

[aviad rozenhek]

On Tue, Nov 10, 2009 at 13:03, Jason Garrett-Glaser
<darkshikari at gmail.com>wrote:

> On Tue, Nov 10, 2009 at 2:55 AM, aviad rozenhek <aviadr1 at gmail.com> wrote:
> >>
> >>
> >> The problem is that this changes the way the presets work.  Currently:
> >>
> >> preset is applied
> >>
> >> tune is applied
> >>
> >> all other settings are applied
> >>
> >> profile is applied
> >>
> >> Your method makes them applied in commandline order, which may confuse
> >> some users (especially with regard to --profile).  It would make more
> >> sense, IMO, to have param_default() take a preset and tuning as an
> >> argument, for example.
> >>
> >> Dark Shikari
> >
> > I left the logic in x264.c intact, so preset, tune. other_settings,
> >  profiles are still applied in order.
> > so they are not applied in commandline order.
>
> Yes, but the order will still be different when used from *other*
> applications, which will only serve to confuse users.
>
> Dark Shikari
>

as an application developer myself, I already have similar parameter-order
logic in my application, since even before the introduction of the --preset,
--tune flags to x264.
the only difference is that without this patch I need to maintain presets
myself and find it hard to compare my application's settings with
commandline settings,

-- 
Aviad Rozenhek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20091110/0fc44e35/attachment.htm>