[x264-devel] pic_struct / hrd patch

[Alex Giladi]

Attached is a new version of the patch.
This is a fix to the snafu detected by shon3i (on Doom9), where the
sizes/rates were assumed to be in units of 1024 bits, while they are
actually in 1000's.
Thanks to all the brave people who are using the patch and reporting
back the problems!
Alex (a.k.a. Zm_Gorynych on #x264dev).

On Sat, Nov 21, 2009 at 2:48 AM, Alex Giladi <alex.giladi at gmail.com> wrote:
> Attached is a modified version (note: this is the same version as
> published in Doom9 today as http://pastebin.com/d72a44cf2).
> The patch has same functionality as the previous version, and has some
> parameter handling changes. Also, it removes 'panic factor' which was
> earlier applied to the HRD buffer parameters.
> Alex.
>
> On Thu, Nov 19, 2009 at 12:36 AM, Alex Giladi <alex.giladi at gmail.com> wrote:
>> Attached is the fixed and updated version of the HRD patch.
>> Trahald was right (thanks!), and the VBV fullness routine was really broken.
>> Alex.
>>
>> On Fri, Oct 16, 2009 at 8:45 AM, Trahald <wewk584 at gmail.com> wrote:
>>> I think your x264_vbv_fullness() routine is broken. initial cpb removal
>>> delay is holding negative values. it is what is causing elecard to reject
>>> the stream.
>>>
>>> On Mon, Oct 12, 2009 at 10:34 AM, Alex Giladi <alex.giladi at gmail.com> wrote:
>>>>
>>>> Anyone that sees a problem with this patch -- can you please provide
>>>> some details?
>>>> Thanks!
>>>> Alex.
>>>>
>>>> On Sun, Oct 11, 2009 at 3:31 PM, Jason Garrett-Glaser
>>>> <darkshikari at gmail.com> wrote:
>>>> > On Wed, Oct 7, 2009 at 12:03 PM, Alex Giladi <alex.giladi at gmail.com>
>>>> > wrote:
>>>> >> Attached is the new version of the HRD patch with several changes due
>>>> >> to the inputs from Dark_Shikari, Manao and Trahald.
>>>> >> The two major fixes cpb_removal_delay for IDR frames and calculation
>>>> >> of initial_cpb_removal_delay.
>>>> >> Alex.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-r1342-nal_hrd-pic_struct-v11.patch
Type: application/octet-stream
Size: 37579 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20091122/8df24620/attachment-0001.obj>