[x264-devel] [PATCH] MPEG2 Program Stream output

[Gil Pedersen]

On 21/01/2011, at 17.34, Lorenzo Pallara wrote:

Attached patch is to add MPEG2 Program Stream output to x264.

My proposal is to use ".pes" as filename extension as I can't find a
more popular one.

Looking at the code I can see that it's not an MPEG2 Program Stream you output, but rather a "PES Stream". A proper program stream will need some header and trailer bytes and should have a number of additional "pack" headers.

Naming aside, I'm a bit concerned that you never calculate and specify the PES_packet_length. As far as I can tell, according to 13818-1, this is only allowed if you encapsulate the PES Stream into Transport Stream packets, but not Program Stream packets.

Regards,
Gil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20110125/cd0771a6/attachment.html>