[x264-devel] Intel Compiler support

[Dennis Munsie]

I agree it's a bit of an odd way to set it up, but we normally don't use the setup script for our build system at work so I don't typically use the setup script.  I went back and retested using the setup script and I get the same results with 11.1 build 72.  With 12.0.2 20110112, it recognizes the gnu99 as a valid option and all works as it should.

The patch that was provided earlier doesn't seem to have any bad effects and allows it to work with more version of the Intel compiler - given that some people might not have access to the latest update, it seems like a nice thing to do.

dennis

On Mar 24, 2011, at 7:02 PM, Steven Walters wrote:

> you appear to be initializing icc in a odd way,
> the proper way is to use the proper iccvars.sh script to initialize
> the environment,
> not simply add icc's bin folder to the path.
> 
> Also, I tested the committed patch against 11.1 and 12.0 on my debian
> system and there were no issues such as this.
> 
> Looks like i'll need to get my debian system back up and running after
> it went down from an upgrade to squeeze...
> 
> On Thu, Mar 24, 2011 at 4:31 PM, Dennis Munsie <dmunsie at gmail.com> wrote:
>> Just tried the patch out -- worked perfectly.
>> 
>> Thanks for the quick turnaround, very much appreciated.
>> 
>> dennis
>> 
>> On Mar 24, 2011, at 4:06 PM, BugMaster wrote:
>> 
>>> On Thu, 24 Mar 2011 15:50:37 -0400, Dennis Munsie wrote:
>>>> That was the problem -- I'm downloading the latest version as I
>>>> speak, but is there any reason in particular that the version in git
>>>> couldn't default to c99 instead of gnu99?
>>> 
>>>> Also, in my quick testing using some of my own code I have around,
>>>> I didn't see any improvement in performance when compiling libx264
>>>> with icc instead of gcc.  I'm guessing that has more to do with my
>>>> own code than anything else, but I was curious if there were any
>>>> improvements (or slowdowns, even) seen in x264 because of the switch to icc?
>>> 
>>>> Thanks!
>>>> dennis
>>> 
>>> Before trying new version of icc please check would this patch fix the
>>> problem (correctly detect that -std=gnu99 not supported).<patch.diff>_______________________________________________
>>> x264-devel mailing list
>>> x264-devel at videolan.org
>>> http://mailman.videolan.org/listinfo/x264-devel
>> 
>> _______________________________________________
>> x264-devel mailing list
>> x264-devel at videolan.org
>> http://mailman.videolan.org/listinfo/x264-devel
>>