[x264-devel] [PATCH] Do not play with cflags on AArch64
Janne Grunau
janne-x264 at jannau.net
Tue Jul 21 22:06:34 CEST 2015
On 2015-06-01 11:24:45 +0200, Marcin Juszkiewicz wrote:
> x264 has AArch64 support. But I had to remove some lines from it's
> configure script to make it build.
>
> All because it tries to be too smart. Sure, there is no need to check
> for NEON as on this architecture it is mandatory. But I left code for
> it alone. But there is no such switch in gcc as "-arch" one so let's
> kill line which tries to add it.
>
> Index: x264-0.142-20141221-6a301b6/configure
> ===================================================================
> --- x264-0.142-20141221-6a301b6.orig/configure
> +++ x264-0.142-20141221-6a301b6/configure
> @@ -788,9 +788,6 @@ if [ $asm = auto -a $ARCH = ARM ] ; then
> fi
>
> if [ $asm = auto -a $ARCH = AARCH64 ] ; then
> - # set flags so neon is built by default
> - echo $CFLAGS | grep -Eq '(-mcpu|-march|-mfpu|-arch)' || CFLAGS="$CFLAGS -arch arm64 -mfpu=neon"
> -
I guess it's the result of me not compiling natively but only cross for
linux. The syntax suggests I added it for Xcode's benefit but I don't
remember why I did it.
patch ok, if there are any problems or desires to add this again we can
add something which works with all public arm64 compilers.
Janne
More information about the x264-devel
mailing list