[x264-devel] patch[1/1]: fix bug to disable altivec when set--disable-asm

[rongyan]

Hi,
 Your patch is very nice to solve one of the problems, but not all.
 There are two misses:
 1. in configure file, need to modify "=" to "==" in line 715. It is to fix the bug when --disable-asm is added, the altivec optimizaiton can be really disabled.
 2. in common/cpu.c, beside your modification, also need to look at the branch: #elif SYS_LINUX, when HAVE_ALTIVEC is disable, need to return 0. It is to fix the reporting problem.
 See my original attchment for more details.
  
 Thanks for your quick reply.
 Rong Yan
  
 ------------------  
   The world has enough for everyone's need, but not enough for everyone's greed.



  
  

 

 ------------------ Original ------------------
  From:  "BugMaster";<BugMaster at narod.ru>;
 Date:  Tue, Jan 12, 2016 02:47 AM
 To:  "Mailing list for x264 developers"<x264-devel at videolan.org>; 
 
 Subject:  Re: [x264-devel] patch[1/1]: fix bug to disable altivec when set--disable-asm

 

On Mon, 11 Jan 2016 16:12:59 +0800, rongyan wrote:
> Hi, Here attach a patch to fix the bug on POWER. When set
> --disable-asm, the altivec can not be really disabled in original
> version. With this patch, it works.   Thanks. Rong Yan    
>  
Hi. As I understand it was only cosmetic bug of reporing:
x264 [info]: using cpu capabilities: Altivec
while none was really compiled or used.

As I understand my attached patch is enough to fix it.
Report if it fix your problem (I can't really test PowerPC).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20160112/8faef10c/attachment.html>