[x264-devel] patch[1/1]: fix bug to disable altivec when set--disable-asm

[BugMaster]

12.01.2016, 10:47, "rongyan" <rongyan236 at foxmail.com>:
> Hi,
> Your patch is very nice to solve one of the problems, but not all.

Have you even tried it (compiled/run it)?

> There are two misses:
> 1. in configure file, need to modify "=" to "==" in line 715. It is to fix the bug when --disable-asm is added, the altivec optimizaiton can be really disabled.

"=" and "==" are equal in bash (this is not C).
And according to http://www.gnu.org/software/bash/manual/html_node/Bash-Conditional-Expressions.html#Bash-Conditional-Expressions "=" form is more POSIX conformant.

> 2. in common/cpu.c, beside your modification, also need to look at the branch: #elif SYS_LINUX, when HAVE_ALTIVEC is disable, need to return 0. It is to fix the reporting problem.
> See my original attchment for more details.

"#elif SYS_LINUX" - is continuation of "#if SYS_MACOSX || SYS_OPENBSD || SYS_FREEBSD" which is already inside "#elif ARCH_PPC" which I changed.