[x264-devel] [PATCH] arm: Always unconditionally declare .arch armv7-a

Martin Storsjö martin at martin.st
Thu May 4 21:00:51 CEST 2017


We already unconditionally declare .fpu neon and try to build all the
neon codepaths (but only execute them conditionally based on a runtime
check).

This fixes builds targeting armv6, where the rbit instruction isn't
available. This instruction is only used within a neon function in
any case, so there's little point in emulating it.
---
Rebased on top of the latest sandbox.
---
 common/arm/asm.S | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/common/arm/asm.S b/common/arm/asm.S
index c46b61b..0472d11 100644
--- a/common/arm/asm.S
+++ b/common/arm/asm.S
@@ -29,14 +29,7 @@
 .syntax unified
 
 #ifndef __APPLE__
-#if   HAVE_NEON
-        .arch           armv7-a
-#elif HAVE_ARMV6T2
-        .arch           armv6t2
-#elif HAVE_ARMV6
-        .arch           armv6
-#endif
-
+.arch armv7-a
 .fpu neon
 #endif
 
-- 
2.1.4



More information about the x264-devel mailing list