[x264-devel] [PATCH] This change modifies x264_threadpool_t->exit to be volatile, preventing a benign data race warning from clang's ThreadSanitizer.

[Daniel Deptford]

Is this change acceptable?  Please let me know if you'd like me to make any
changes.

Thanks,

Daniel

On Tue, Dec 11, 2018 at 11:11 AM Daniel Deptford <ddeptford at google.com>
wrote:

> ---
>  common/threadpool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/threadpool.c b/common/threadpool.c
> index 7f98f778..4d36105b 100644
> --- a/common/threadpool.c
> +++ b/common/threadpool.c
> @@ -34,7 +34,7 @@ typedef struct
>
>  struct x264_threadpool_t
>  {
> -    int            exit;
> +    volatile int   exit;
>      int            threads;
>      x264_pthread_t *thread_handle;
>      void           (*init_func)(void *);
> --
> 2.20.0.rc2.403.gdbc3b29805-goog
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20181217/ebc0471e/attachment.html>