[x264-devel] [PATCH] This change modifies x264_threadpool_t->exit to be volatile, preventing a benign data race warning from clang's ThreadSanitizer.

BugMaster BugMaster at narod.ru
Tue Dec 18 19:02:56 CET 2018


On Mon, 17 Dec 2018 12:49:30 -0800, Daniel Deptford wrote:
> Is this change acceptable?  Please let me know if you'd like me to make any changes.


> Thanks,


Hi. Yes. As it is what I suggested myself it is of course OK with me.
Can you post more about what ThreadSanitizer outputed before this
patch and after this patch (simple email no need to resend patch).
As I don't have Linux machine at hand I can't run with ThreadSanitizer
myself (not supported at Windows).

P.S. To commit it to official repo we may need you to sign CLA.
Or we can re-author it as it mostly trivial change suggested by me and
refer to your bug report contribution in commit message.



More information about the x264-devel mailing list