[x264-devel] [PATCH v2 1/8] configure: replace all uses of echo with non-POSIX flags with printf

Ethan Sommer e5ten.arch at gmail.com
Thu Jan 16 22:23:35 CET 2020


---
 configure | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 181a67be..02c44c1a 100755
--- a/configure
+++ b/configure
@@ -59,7 +59,7 @@ exit 1
 fi
 
 log_check() {
-    echo -n "checking $1... " >> config.log
+    printf 'checking %s... ' "$1" >> config.log
 }
 
 log_ok() {
@@ -100,7 +100,7 @@ cc_cflags() {
         fi
         [ $compiler = CL -a "$arg" = -O3 ] && arg=-O2
 
-        [ -n "$arg" ] && echo -n "$arg "
+        [ -n "$arg" ] && printf '%s ' "$arg"
     done
 }
 
@@ -123,7 +123,7 @@ cl_ldflags() {
         [ "$arg" = gpac_static.lib ] && arg=libgpac_static.lib
         [ "$arg" = x264.lib ] && arg=libx264.lib
 
-        [ -n "$arg" ] && echo -n "$arg "
+        [ -n "$arg" ] && printf '%s ' "$arg"
     done
 }
 
@@ -187,7 +187,7 @@ cpp_check() {
     for arg in $1; do
         echo "#include <$arg>" >> conftest.c
     done
-    echo -e "#if !($3) \n#error $4 \n#endif " >> conftest.c
+    printf '#if !(%s) \n#error %s \n#endif \n' "$3" "$4" >> conftest.c
     if [ $compiler_style = MS ]; then
         cpp_cmd="$CC conftest.c $(cc_cflags $CFLAGS $2) -P"
     else
-- 
2.25.0



More information about the x264-devel mailing list