[x265] [PATCH RFC] presets: adjust presets to increase spread and align closer with x264 presets

[Steve Borho]

On Thu, Nov 7, 2013 at 4:07 AM, Deepthi Nandakumar <
deepthi at multicorewareinc.com> wrote:

> Since the default preset is medium, shouldnt x265_param_default apply
> medium settings only? So that the if (!strcmp(preset, "medium")) block here
> is empty??
> In that case, the preset (if specified) will change only the ones which
> are different from medium?
>

that is where we need to get to; once we've settled on the contents of
medium preset


>
> Also, there are a few params here that
> 1. arent used and arent initialised properly (eg, constrainedIntra,
> weightedBipred)  lets remove them and add them back when the feature exists.
>

no argument from me, though I suspect constrained intra is already
functional from the HM code.  We just haven't made it a priority to test.


> 2. that are dependent on other param fields, like EnableRdo, EnabledRDOQ
> depends on RDLevel. This particular case is handled safely inside
> encoder::configure, but not sure about all such cases.
>
> Just thought this is a good time for springcleaning.
>

Yes, in my view EnabledRDOQ and EnableRdo should be removed, and the
internal code should use RDLevel directly.


>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>


-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20131107/7e034e40/attachment.html>