[x265] [PATCH RFC] cpu-a: remove unused safe_intel_cpu_indicator_init routine

[Steve Borho]

On Sat, Oct 5, 2013 at 2:14 PM, Steve Borho <steve at borho.org> wrote:

>
>
>
> On Sat, Oct 5, 2013 at 1:00 PM, Derek Buitenhuis <
> derek.buitenhuis at gmail.com> wrote:
>
>> On 10/4/2013 12:22 AM, Derek Buitenhuis wrote:
>> > Queued to test tomorrow morn.
>>
>
> Thanks for testing
>
> Findings:
>> t
>> Lib links via:
>>
>> /usr/bin/c++  -fPIC  -fPIC -O3 -DNDEBUG  -shared -Wl,-soname,libx265.so
>> -o libx265.so CMakeFiles/x265.dir/dllmain.cpp.o common/libcommon.a
>> encoder/libencoder.a common/vec/libPrimitivesVec.a
>> common/x86/libPrimitivesASM.a -lpthread -lm -lrt
>>
>
> this looks somewhat sane, ignoring the redundant -fPIC.  Though I wonder
> if the link order is wrong for GCC.  It might be discarding much of
> libcommon.a because it is listed before libencoder.a
>

I found that the second patch was unnecessary once I changed the order of
the libraries, and now the shared library is much larger than the
executable so I've pushed the first patch with those changes.

I couldn't figure out why cmake is linking the static libs into the
executable, but it didn't seem like a problem that should hold up shared
library support.

Let me know if you run into any further problems with it.

Thanks

--
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20131006/838e3cf5/attachment.html>