[x265] [PATCH Review Only] filterHorizontal_p_p_4, 4x4 asm code

[Praveen Tiwari]

Yes, that is (r6m) for coefficients we are loading from stack, is why that
comments seems helpful to me at this stage.

Regards,
Praveen


On Tue, Oct 8, 2013 at 11:44 AM, chen <chenm003 at 163.com> wrote:

>
> +;-----------------------------------------------------------------------------
> +; void filterHorizontal_p_p_4(pixel *src, intptr_t srcStride, pixel *dst,
> intptr_t dstStride, int width, int height, short const *coeff)
>
>
> I assume this comment is out of date?  you shouldn't need to pass width
> and height
>
>
>>
>> +;-----------------------------------------------------------------------------
>> +INIT_XMM sse4
>> +cglobal filterHorizontal_p_p_4, 4, 5, 5, src, srcstride, dst, dststride
>> +    mov         r4,         r6m
>>
>> They use r6m, so the comment is right, maybe need sync the code
>>
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20131008/70e5c02e/attachment.html>