[x265] [PATCH] common : Added new function x265_param2string

[Rafaël Carré]

Hello,

Le 16/10/2013 13:50, Gopu Govindaswamy a écrit :
> # HG changeset patch
> # User Gopu Govindaswamy <gopu at multicorewareinc.com>
> # Date 1381924237 -19800
> # Node ID 5ad0aaa72d6ef149a63cd979751c86b3fed48855
> # Parent  d84ba96117b5c9f41361967211f524d459c2cd0b
> common : Added new function x265_param2string
> 
> diff -r d84ba96117b5 -r 5ad0aaa72d6e source/common/common.cpp
> --- a/source/common/common.cpp	Wed Oct 16 16:06:12 2013 +0530
> +++ b/source/common/common.cpp	Wed Oct 16 17:20:37 2013 +0530

That file looks good,

> diff -r d84ba96117b5 -r 5ad0aaa72d6e source/common/common.h
> --- a/source/common/common.h	Wed Oct 16 16:06:12 2013 +0530
> +++ b/source/common/common.h	Wed Oct 16 17:20:37 2013 +0530
> @@ -73,6 +73,7 @@
>  #define MAX_NAL_UNITS 5
>  #define MIN_FIFO_SIZE 1000
>  #define EMULATION_SIZE 1000
> +#define PARAM_BUFF_SIZE 5000

I think this value does not need to be put in a header, there is no
point in sharing it with other files.

>  #define CHECKED_MALLOC(var, type, count)\
>  {\
> @@ -114,5 +115,6 @@
>  int  x265_check_params(x265_param_t *param);
>  void x265_print_params(x265_param_t *param);
>  int x265_set_globals(x265_param_t *param);
> +char *x265_param2string( x265_param_t *p);
>  
>  #endif // ifndef X265_COMMON_H

Thanks, can't wait for x265_param_parse :)