[x265] [PATCH] Add Windows XP support in MSVC11 builds

[Steve Borho]

On Tue, Oct 15, 2013 at 11:53 PM, Kurtnoise <kurtnoise at free.fr> wrote:

> Hi,
>
> XP plateforms require v110_xp as toolset instead of v110. Otherwise,
> applications don't run correctly on this plateform.
>
> This patch requires CMake 2.8.11. The flag dedicated to the toolset has
> been fixed in this version.
>
> Regards,
> Kurtnoise
>
> # HG changeset patch
> # User Kurtnoise <kurtnoise at free.fr>
> # Date 1381898006 -7200
> #      Wed Oct 16 06:33:26 2013 +0200
> # Node ID 723e554191e14e6289342043225e48**5e656c27d7
> # Parent  a998daed845922b3b880b48c0cafa3**2c422c941e
> Add Windows XP support in MSVC11 builds. This requires CMake 2.8.11 or
> later.
>
> diff -r a998daed8459 -r 723e554191e1 build/vc11-x86/make-solutions.**bat
> --- a/build/vc11-x86/make-**solutions.bat    Tue Oct 15 20:57:47 2013
> -0500
> +++ b/build/vc11-x86/make-**solutions.bat    Wed Oct 16 06:33:26 2013
> +0200
> @@ -3,4 +3,4 @@
>  :: run this batch file to create a Visual Studion solution file for this
> project.
>  :: See the cmake documentation for other generator targets
>  ::
> -cmake -G "Visual Studio 11" ..\..\source && cmake-gui ..\..\source
> +cmake -G "Visual Studio 11" -T "v110_xp" ..\..\source && cmake-gui
> ..\..\source
> diff -r a998daed8459 -r 723e554191e1 build/vc11-x86_64/make-**
> solutions.bat
> --- a/build/vc11-x86_64/make-**solutions.bat    Tue Oct 15 20:57:47 2013
> -0500
> +++ b/build/vc11-x86_64/make-**solutions.bat    Wed Oct 16 06:33:26 2013
> +0200
> @@ -3,4 +3,4 @@
>  :: run this batch file to create a Visual Studion solution file for this
> project.
>  :: See the cmake documentation for other generator targets
>  ::
> -cmake -G "Visual Studio 11 Win64" ..\..\source && cmake-gui ..\..\source
> +cmake -G "Visual Studio 11 Win64" -T "v110_xp" ..\..\source && cmake-gui
> ..\..\source
>

I can't take this because it requires a new SP release of VC11 and there' s
no clear way to test for that SP in this batch file.

This detail should go into the build/README and/or on the Wiki.



> diff -r a998daed8459 -r 723e554191e1 source/CMakeLists.txt
> --- a/source/CMakeLists.txt    Tue Oct 15 20:57:47 2013 -0500
> +++ b/source/CMakeLists.txt    Wed Oct 16 06:33:26 2013 +0200
> @@ -7,7 +7,7 @@
>  endif()
>
>  project (x265)
> -cmake_minimum_required (VERSION 2.8.8) # OBJECT libraries require 2.8.8
> +cmake_minimum_required (VERSION 2.8.11) # OBJECT libraries require 2.8.11
>
>  # X265_BUILD must be incremented each time the public API is changed
>  set(X265_BUILD 1)
>
-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20131020/62be1b38/attachment.html>