[x265] [PATCH] framefilter: we not need a row delay on loopfilter disable mode, more clear code to call processRow on last rows

Derek Buitenhuis derek.buitenhuis at gmail.com
Wed Sep 11 16:36:44 CEST 2013


On Wed, Sep 11, 2013 at 3:32 PM, Min Chen <chenm003 at 163.com> wrote:
> # HG changeset patch
> # User Min Chen <chenm003 at 163.com>
> # Date 1378909245 -28800
> # Node ID 543412d6e98e1047ed4722f9780268753b4bf8dc
> # Parent  9a956054f2f7971e7eab05281bc0857558091d87
> framefilter: we not need a row delay on loopfilter disable mode, more clear code to call processRow on last rows

[...]

> -        int lag = m_filterRowDelay;
> -        while (--lag)
> -            m_frameFilter.processRow(row - lag);
> -        m_frameFilter.processRow(row);
> +         for(int i = m_numRows - m_filterRowDelay; i < m_numRows; i++)
> +             m_frameFilter.processRow(i);
>          m_completionEvent.trigger();

You've accidentally indented by an extra space here.

Looks good to me if you fix that, and change the message to:

    framefilter: Make code clearer

    We do not need the row delay when the loopfilter is disabled.

- Derek


More information about the x265-devel mailing list