[x265] [PATCH] List: Basic List Operations To Replace std::list

[Derek Buitenhuis]

On 9/12/2013 8:54 AM, Gopu Govindaswamy wrote:
> # HG changeset patch
> # User Gopu Govindaswamy <gopu at multicorewareinc.com>
> # Date 1378972464 -19800
> # Node ID 7be0ceae34e059849737050c52a326becd8bbf1a
> # Parent  0482a5c72c21dc14d6be5f4b9c4ffe2ae574ebc3
> List: Basic List Operations To Replace std::list

I still do not understand the benefit of rewriting a subset of std::list
in C++. What's the end goal? It is not clear.

> +#ifndef __LIST__
> +#define __LIST__

Header guards should always be prefixed/namespaced. __LIST__
is far too generic and could very easily conflict with
system headers.

> +#endif // ifndef __COMMON__

Wrong comment. Copypasta code is Bad™.

- Derek