[x265] [PATCH] framefilter: comment cleanups, use pixel data type

[Steve Borho]

On Fri, Sep 13, 2013 at 5:01 AM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 9/13/2013 7:29 AM, Steve Borho wrote:
> > # HG changeset patch
> > # User Steve Borho <steve at borho.org>
> > # Date 1379053732 18000
> > #      Fri Sep 13 01:28:52 2013 -0500
> > # Node ID 42faf1cb4d7b1cf6b0323fa4abc82a31c8eed270
> > # Parent  17d41a7563aaa090b47377dac317437d7733844a
> > framefilter: comment cleanups, use pixel data type
>
> [...]
>
> > -            // TODO: this code is NOT VERIFY because TransformSkip and
> PCM mode have some bugs, they always not active!
> > +            // TODO: this code is NOT VERIFY because TransformSkip and
> PCM modes have some bugs, they are never enabled
>
> s/VERIFY/VERIFIED/
>

yeah, I should improve the english there a bit more


>
> > -        // TODO: this code is NOT VERIFY because TransformSkip and PCM
> mode have some bugs, they always not active!
> > +        // TODO: this code is NOT VERIFY because TransformSkip and PCM
> modes have some bugs, they are never enabled
>
> Ditto.
>
> > -    PPAScopeEvent(Thread_filterCU);
> > -
>
> This is the only change I'm not sure about. How is it related?
>

This is a really minor but unrelated bug fix.  I can move it into a
separate patch.

The PPAScopeEvent macro causes a bar to appear in our profiler with the
given name, associated with the CPU core and start/stop time.  The problem
with this particular instance is that the function was copy-pasted from
another in this file and this profile scope came along for the ride and
since they both have the same name and one calls the other it is
essentially a NOP.

-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130913/edc77182/attachment.html>