[x265] [PATCH] Resolve some patching issues for previous patch (deadlock)

chen chenm003 at 163.com
Tue Sep 17 17:24:41 CEST 2013


Oh, I think we need mask, because it is really ready task , the execute id get from it

At 2013-09-17 21:43:02,"Derek Buitenhuis" <derek.buitenhuis at gmail.com> wrote:
>On 9/17/2013 2:11 PM, Min Chen wrote:
>> # HG changeset patch
>> # User Min Chen <chenm003 at 163.com>
>> # Date 1379423463 -28800
>> # Node ID c5c645aa14bfdbf482186730c59a000fdae10e07
>> # Parent  0d33ff236f68bc2238138a7213301b2efc0e6426
>> Resolve some patching issues for previous patch (deadlock).
>
>Can you add a short description of how it is fixed to
>the commit message?
>
>Much of the patch is confusing without context.
>
>>              uint64_t oldval = m_queuedBitmap[w];
>> -            if (oldval == 0) // race condition
>> +            uint64_t mask = m_queuedBitmap[w] & m_enableBitmap[w];
>> +            if (mask == 0) // race condition
>>                  break;
>
>if (!(oldval & m_enableBitmap[w]))
>    break;
>
>No need for a new stack var. Just a matter of preference; feel
>free to ignore.
>
>- Derek
>_______________________________________________
>x265-devel mailing list
>x265-devel at videolan.org
>https://mailman.videolan.org/listinfo/x265-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130917/00b016e1/attachment.html>


More information about the x265-devel mailing list