[x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

Steve Borho steve at borho.org
Thu Sep 19 18:47:17 CEST 2013


On Thu, Sep 19, 2013 at 7:02 AM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 9/19/2013 10:16 AM, Min Chen wrote:
> > +// Disabled because Frame Parallelism call processRowPost early, it is
> broken data.
> > +// OPT("sao-lcu-opt",
> param->saoLcuBasedOptimization,required_argument, 0, "0: SAO picture-based
> optimization, 1: SAO LCU-based optimization ")
>
> ... Why not fix it instead of commenting stuff out?
>

I think I agree; we should keep the feature but don't allow an encoder to
use it in combination with frame threads.  For lower CPU core counts, this
will still be quite feasible.

-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130919/8163c340/attachment.html>


More information about the x265-devel mailing list