[x265] [PATCH Review Only] Assembly routine for filterHorizontal_p_p() for 4 tap filter

Jason Garrett-Glaser jason at x264.com
Mon Sep 23 16:55:57 CEST 2013


> +    cmp         col,        width
> +    jge         _end_col
> +
> +    jmp         _loop_col

I don't understand these loop conditions.  A loop should be like this:

.loop:
<stuff>
sub counter, val
jge .loop

or

.loop:
<stuff>
add counter, val
cmp counter, max
jl .loop

There shouldn't be two different jumps in a loop condition like this.

Jason


More information about the x265-devel mailing list