[x265] [PATCH 2/5][RFC] uncrustify: Do not include binary

Steve Borho steve at borho.org
Mon Sep 23 19:40:16 CEST 2013


On Mon, Sep 23, 2013 at 12:14 PM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> It's very stupid to include an easily available binary in
> a version control system.
>


This is one of the rules I am normally religious about; don't check in
machine generated files.  But in this case I accepted these small
executables for the premise it would be more likely the developers would
cleanup their code before checking it in.

Now that code contributions are being forced through the mailing list, I
think we can drop the binaries


>
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  doc/uncrustify/drag-uncrustify.bat |   2 +-
>  doc/uncrustify/uncrustify.exe      | Bin 497664 -> 0 bytes
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  delete mode 100644 doc/uncrustify/uncrustify.exe
>
> diff --git a/doc/uncrustify/drag-uncrustify.bat
> b/doc/uncrustify/drag-uncrustify.bat
> index b61f665..380beea 100644
> --- a/doc/uncrustify/drag-uncrustify.bat
> +++ b/doc/uncrustify/drag-uncrustify.bat
> @@ -4,7 +4,7 @@
>  ::  project's coding style to the file.  This will likely overwrite the
>  ::  original file, so use with care
>
> -%~dp0\uncrustify.exe -f "%1" -c %~dp0\codingstyle.cfg -o indentoutput.tmp
> +uncrustify.exe -f "%1" -c %~dp0\codingstyle.cfg -o indentoutput.tmp
>  move /Y indentoutput.tmp "%1"
>
>  pause
> diff --git a/doc/uncrustify/uncrustify.exe b/doc/uncrustify/uncrustify.exe
> deleted file mode 100644
> index
> 9e69152638010b35d438d768ee9ca1cfff940054..0000000000000000000000000000000000000000
> --
> 1.8.4
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>



-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130923/ae55e434/attachment.html>


More information about the x265-devel mailing list