[x265] [PATCH] Encoder: do not use std::list for the class AccessUnit

Jean-Baptiste Kempf jb at videolan.org
Tue Sep 24 15:36:46 CEST 2013


On 24 Sep, Gopu Govindaswamy wrote :
> @@ -173,7 +175,7 @@
>   \param   accessUnitsOut      output bitstream
>   \retval                      number of encoded pictures
>   */
> -int TEncTop::encode(bool flush, const x265_picture_t* pic_in, x265_picture_t *pic_out, AccessUnit& accessUnitOut)
> +int TEncTop::encode(bool flush, const x265_picture_t* pic_in, x265_picture_t *pic_out, NALUnitEBSP **nalunits)


Please update the doxygen above the function.

> -    for (AccessUnit::const_iterator it = accessUnit.begin(); it != accessUnit.end(); it++)
> +    int count = 0;
> +    for (;nalunits[count] != NULL; count++)

You should be able to define the count in the for first parameter, if I
am not mistaken.

The rest, LGTM.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the x265-devel mailing list