[x265] Fwd: [PATCH] asm code for ipfilterH_pp, 4 tap filter

Praveen Tiwari praveen at multicorewareinc.com
Sat Sep 28 08:52:20 CEST 2013


> +_loop_row:
> +    xor         col,        col
> +    cmp                width,      0
> +    je         _end_col

>>I don't understand this. Why do we have to do this check?

suppose, during execution width comes less than 8 like 5, then we would
like to run our code section which handles the reaming width (_end_col:)
not the whole code (handle multiple of 8 and renaming width part, it will
computed twice in this case and  corrupting some (8 - widthleft) dst[] old
values which is being used with 'pblenvb' instruction.This is why we have
put a check. if width is always >= 8 you are right, we don't need to put
the check. *I have sent this text as common reply, my mistake if you are
reading this please, ignore that.*

Regards,
praveen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130928/205145a3/attachment.html>


More information about the x265-devel mailing list