[x265] [PATCH REVIEW] Generating weighted full-pels in compressCTURows

[Shazeb Khan]

On Fri, Sep 27, 2013 at 10:19 PM, Steve Borho <steve at borho.org> wrote:

>
>
>
> On Fri, Sep 27, 2013 at 11:30 AM, Jean-Baptiste Kempf <jb at videolan.org>wrote:
>
>> On 27 Sep, shazeb at multicorewareinc.com wrote :
>> > -        X265_FREE(fpelPlane);
>> > +        X265_FREE(fpelPlane - m_startPad);
>>
>> Is this always allowed?
>>
>
> It's not robust, this if statement also needs to verify refPlane is not
> NULL  applyWeight() also needs to check for earlier malloc failure and
> early-out.
>

What shall be the proper way to handle this condition in applyWeight():
when fpelPlane has no allocation.

One way out is to have a flag in MotionReference object which must be set
'false' on malloc fail ('true' by default); and this flag must be checked
before calling applyweight() and using the weighted pixels.
But the problem with this approach will be that the condition will stay
unreported.

Any suggestions?



Shazeb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130930/d87f50bf/attachment.html>