[x265] [PATCH] fix build error on VS2008 + WinXP
Steve Borho
steve at borho.org
Fri Apr 11 21:15:22 CEST 2014
On Thu, Apr 10, 2014 at 9:36 PM, chen <chenm003 at 163.com> wrote:
> At 2014-04-11 02:03:29,"Steve Borho" <steve at borho.org> wrote:
>
>>On Thu, Apr 10, 2014 at 4:38 AM, Min Chen <chenm003 at 163.com> wrote:
>>> # HG changeset patch
>>> # User Min Chen <chenm003 at 163.com>
>>> # Date 1397122677 -28800
>>> # Node ID 88365d9b50a56ff468b54b4d42f18d5644a9f79f
>>> # Parent 83ccf2f1453ffd91c9fd8b84b72e3d3daacba6c6
>>> fix build error on VS2008 + WinXP
>>>
>>> diff -r 83ccf2f1453f -r 88365d9b50a5 source/common/winxp.cpp
>>> --- a/source/common/winxp.cpp Thu Apr 10 11:17:46 2014 +0530
>>> +++ b/source/common/winxp.cpp Thu Apr 10 17:37:57 2014 +0800
>>> @@ -23,7 +23,7 @@
>>>
>>> #include "threading.h"
>>>
>>> -#if defined(_WIN32) && (_WIN32_WINNT <_WIN32_WINNT_VISTA)
>>> +#if defined(_WIN32) && (_WIN32_WINNT <= _WIN32_WINNT_WINXP)
>>
>>What is the build error you see? And what is your _WIN32_WINNT value?
>>
>>See 6630 (ae07405973b7) xp: fix header guards for XP support, fixes MinGW
>> build
>>
> Thanks!
> The VS2008 default SDK didn't define WIN32_WINNT_VISTA
I guess we should use the actual value of WIN32_WINNT_VISTA there then
--
Steve Borho
More information about the x265-devel
mailing list