[x265] ASM crash in r6706

[chen]

At 2014-04-17 00:28:04,"Steve Borho" <steve at borho.org> wrote:
>On Wed, Apr 16, 2014 at 8:56 AM, Robert Bacs
><robert.bacs at rapidsolution.ro> wrote:
>> On 4/16/2014 4:26 PM, chen wrote:
>>
>> Thanks your file.
>> I have confirm we crash on stack align problem.
>> The root cause is x264 asm header push some reg into stack, it broken stack
>> align.
>>
>> Could you try to modify CMakeASM_YASMInformation.cmake
>> -DHAVE_ALIGNED_STACK=1 to -DHAVE_ALIGNED_STACK=0
>>
>> Great...now it's working fine
>
>Good to know.
>
>So now I just need to know if this is a Win32 problem, or a more
>generic gcc + 32bit x86 problem.
>
I guess it is x264 asm header bug (x86inc.asm)
GCC pass a align stack to our code, but x264 push some regs to broken it.
In x64, we use extra reg to save temporary data, so it works right, when we use stack temporary memory in future, we will get crash either.
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20140417/fc5b5c69/attachment.html>