[x265] ASM crash in r6706

Steve Borho steve at borho.org
Mon Apr 21 19:43:27 CEST 2014


On Fri, Apr 18, 2014 at 9:12 PM, chen <chenm003 at 163.com> wrote:
>>> In this case, x264asm don't do it because HAVE_ALIGNED_STACK=1
>>> the input stack is aligned, but we need push 3 regs into stack, so we got
>>> a
>>> stack mistake.
>>
>>Again, that's not how it works.
>>
>>HAVE_ALIGNED_STACK means x264asm can assume the input stack is aligned.
>>
>>It does not mean x264asm magically stops handling stack alignment.
>>
>>HAVE_ALIGNED_STACK exists to compensate for compilers such as Intel's
>>that don't perform stack alignment.  It has _absolutely nothing_ to do
>>with x264asm's own pushing registers onto the stack.
>
> Sorry, my mistake.
> Latest version x264asm solve this bug, we x265 use old one, there have a
> condition '%if mmsize <= 16 && HAVE_ALIGNED_STACK'

Min, can you send a patch to bring our headers up to date?

-- 
Steve Borho


More information about the x265-devel mailing list