[x265] [PATCH] testbench: fix crash on downshift and upshift module

Steve Borho steve at borho.org
Tue Apr 22 17:14:43 CEST 2014


On Tue, Apr 22, 2014 at 7:27 AM, Tim Walker <tdskywalker at gmail.com> wrote:
> On 22 Apr 2014, at 08:46, murugan at multicorewareinc.com wrote:
>
>> # HG changeset patch
>> # User Murugan Vairavel <murugan at multicorewareinc.com>
>> # Date 1398149117 -19800
>> #      Tue Apr 22 12:15:17 2014 +0530
>> # Node ID bc8321f5968c829c6f2914b23d9eaa5106485163
>> # Parent  84315557c97ff2b10cf01910d6b131e28fce1781
>> testbench: fix crash on downshift and upshift module
>>
>> Force testbench to pass height and width >= 16, As the encoder prevents encode
>> if height and width of the picture less than 16.
>
> I'm probably being terribly picks, but I would format the commit message differently:
>
> ---
> testbench: make sure width and height are >= 16.
>
> Fixes a crash caused by the encoder refusing to encode if the width or height are less than 16.
> ---
>
> Patch itself looks good.

Actually in this case the crash was only in the test bench, it was
testing a condition that would never occur in the wild, so to speak.

-- 
Steve Borho


More information about the x265-devel mailing list