[x265] [PATCH] Add x265 API defination to api.cpp

Steve Borho steve at borho.org
Tue Feb 25 19:13:24 CET 2014


On Tue, Feb 25, 2014 at 3:07 AM, Deepthi Nandakumar
<deepthi at multicorewareinc.com> wrote:
> Ok, looks good except x265_ssim should not be extern, and should be a part
> of common.cpp and not api.cpp.

So long as x265_ssim() is declared in x265.h, its implementation must
be defined extern "C".

if the declaration is moved to common.h, then we can remove the C
decoration, but we should do that together with all of the pending API
changes so we don't bump the build number too frequently.  The
function is very poorly named, when it is removed from the public API
it should be given a descriptive name.

-- 
Steve Borho


More information about the x265-devel mailing list