[x265] [PATCH] Modify TComSlice structure to support multiple color space formats

[Steve Borho]

On Fri, Jan 3, 2014 at 7:09 AM, <ashok at multicorewareinc.com> wrote:

> # HG changeset patch
> # User ashok at multicorewareinc.com
> # Date 1388754532 -19800
> #      Fri Jan 03 18:38:52 2014 +0530
> # Node ID d7f6034a4ead619cde6977033f908d879789b1d1
> # Parent  d1f5cad1ac2f4394616633751f1b885178848b49
> Modify TComSlice structure to support multiple color space formats
>
> diff -r d1f5cad1ac2f -r d7f6034a4ead source/Lib/TLibCommon/TComSlice.cpp
> --- a/source/Lib/TLibCommon/TComSlice.cpp       Fri Jan 03 18:37:35 2014
> +0530
> +++ b/source/Lib/TLibCommon/TComSlice.cpp       Fri Jan 03 18:38:52 2014
> +0530
> @@ -1077,8 +1077,6 @@
>              m_scalingListCoef[sizeId][listId] = new
> int[X265_MIN(MAX_MATRIX_COEF_NUM, (int)g_scalingListSize[sizeId])];
>          }
>      }
> -
> -    m_scalingListCoef[SCALING_LIST_32x32][3] =
> m_scalingListCoef[SCALING_LIST_32x32][1]; // copy address for 32x32
>  }
>
>  /** destroy quantization matrix array
> diff -r d1f5cad1ac2f -r d7f6034a4ead source/Lib/TLibCommon/TComSlice.h
> --- a/source/Lib/TLibCommon/TComSlice.h Fri Jan 03 18:37:35 2014 +0530
> +++ b/source/Lib/TLibCommon/TComSlice.h Fri Jan 03 18:38:52 2014 +0530
> @@ -778,6 +778,7 @@
>      int         m_SPSId;
>      int         m_VPSId;
>      int         m_chromaFormatIdc;
> +    bool        m_colorPlaneFlag;
>
>      uint32_t    m_maxTLayers;         // maximum number of temporal layers
>
> @@ -863,6 +864,10 @@
>
>      void setChromaFormatIdc(int i)    { m_chromaFormatIdc = i; }
>
> +    void setSeparateColorPlaneFlag(bool c)      { m_colorPlaneFlag = c;}
> +
> +    bool getSeparateColorPlaneFlag()      { return m_colorPlaneFlag;}
>

ugh, please don't add any more set/get methods, just make the variable
public and access it directly.


> +
>      static int getWinUnitX(int chromaFormatIdc) { assert(chromaFormatIdc
> > 0 && chromaFormatIdc <= MAX_CHROMA_FORMAT_IDC); return
> g_winUnitX[chromaFormatIdc]; }
>
>      static int getWinUnitY(int chromaFormatIdc) { assert(chromaFormatIdc
> > 0 && chromaFormatIdc <= MAX_CHROMA_FORMAT_IDC); return
> g_winUnitY[chromaFormatIdc]; }
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>



-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20140107/69161a0e/attachment.html>