[x265] [PATCH] framefilter: remove heap corruption in tld

Steve Borho steve at borho.org
Wed Jul 2 17:54:17 CEST 2014


On Wed, Jul 2, 2014 at 10:35 AM, chen <chenm003 at 163.com> wrote:
> We can reuse [0] everytime, we alloc at least 1 TLD in Encoder::create()

Not if another frame encoder or frame filter can be using it at the
same time; and definitely not if the Encoder's TLD array is static.
This is why the FrameEncoder has it's own m_tld instance, for --no-wpp
operation.

There is a 1::1 correlation between FrameEncoder and FrameFilter, so
it would be appropriate for the FrameFilter to use the FrameEncoder's
reserved m_tld if the FrameFilter functions are not using a worker
thread.

-- 
Steve Borho


More information about the x265-devel mailing list