[x265] Fix dll installation, only affects win32 platforms (mingw)

Steve Borho steve at borho.org
Sat Jul 19 00:03:02 CEST 2014


On 07/18, xantares 09 wrote:
> 
> 
> > Date: Fri, 18 Jul 2014 12:46:34 -0500
> > From: steve at borho.org
> > To: x265-devel at videolan.org
> > Subject: Re: [x265] Fix dll installation,	only affects win32 platforms (mingw)
> > 
> > On 07/17, xantares 09 wrote:
> > > # HG changeset patch
> > > # User xantares <xantares09 at hotmail.com>
> > 
> > We require full names for commit user-name
> Michel Zou
> > 
> > > # Date 1405582179 -7200
> > > # Node ID e16d42ca677c83d9a70e143091949c1861487181
> > > # Parent  f0d157944c556ab6ea77060b5c49093e356664df
> > > Fix dll installation directory.
> > 
> > More info about the bug you are fixing would be useful.
> It fixes the dll install location; it should go to <prefix>/bin, instead of <prefix>/lib.
> > 
> > > diff -r f0d157944c55 -r e16d42ca677c source/CMakeLists.txt
> > > --- a/source/CMakeLists.txt     Thu Jul 17 00:37:00 2014 -0500
> > > +++ b/source/CMakeLists.txt     Thu Jul 17 09:29:39 2014 +0200
> > > @@ -285,7 +285,8 @@
> > >          set_target_properties(x265-shared PROPERTIES VERSION ${X265_LATEST_TAG})
> > >          install(TARGETS x265-shared
> > >                  LIBRARY DESTINATION ${LIB_INSTALL_DIR}
> > > -                ARCHIVE DESTINATION ${LIB_INSTALL_DIR})
> > > +                ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
> > > +                RUNTIME DESTINATION ${BIN_INSTALL_DIR})
> > 
> > Ah, I guess on Windows the DLL is considered a RUNTIME and not a LIBRARY
> Yeah that's it, the shared library (.dll) is considered RUNTIME and the import library (.dll.a on msvc or .lib on msvc)                  as LIBRARY.

ok, pushed with this information added to the commit message and your
full name

-- 
Steve Borho


More information about the x265-devel mailing list