[x265] refine partition size related

Steve Borho steve at borho.org
Tue Jul 22 09:15:53 CEST 2014


On 07/22, Satoshi Nakagawa wrote:
> # HG changeset patch
> # User Satoshi Nakagawa <nakagawa424 at oki.com>
> # Date 1406011990 -32400
> #      Tue Jul 22 15:53:10 2014 +0900
> # Node ID b2ad081e4bfc20bbc84e8bfbab59ed52aeac2a73
> # Parent  d303b4d860e9f06396a156726dd518d0f41fe796
> refine partition size related
> 
> - reorder LumaPartitions to simplify partitionFromLog2Size()
> - remove unused

Queued for testing, thanks.

One question below:

> 
> diff -r d303b4d860e9 -r b2ad081e4bfc source/Lib/TLibCommon/TComYuv.cpp
> --- a/source/Lib/TLibCommon/TComYuv.cpp	Mon Jul 21 22:43:38 2014 -0500
> +++ b/source/Lib/TLibCommon/TComYuv.cpp	Tue Jul 22 15:53:10 2014 +0900
> @@ -127,6 +127,15 @@

<snip>

> diff -r d303b4d860e9 -r b2ad081e4bfc source/test/testbench.cpp
> --- a/source/test/testbench.cpp	Mon Jul 21 22:43:38 2014 -0500
> +++ b/source/test/testbench.cpp	Tue Jul 22 15:53:10 2014 +0900
> @@ -127,6 +127,7 @@
>      EncoderPrimitives cprim;
>      memset(&cprim, 0, sizeof(EncoderPrimitives));
>      Setup_C_Primitives(cprim);
> +    Setup_Alias_Primitives(cprim);
>  
>      struct test_arch_t
>      {
> @@ -186,6 +187,7 @@
>      memset(&optprim, 0, sizeof(optprim));
>      Setup_Instrinsic_Primitives(optprim, cpuid);
>      Setup_Assembly_Primitives(optprim, cpuid);
> +    Setup_Alias_Primitives(optprim);

is there a reason to test the aliased functions, since by their nature
they should already be being tested via another function pointer?

-- 
Steve Borho


More information about the x265-devel mailing list