[x265] [PATCH] Merged TEncCfg into Encoder. A few VUI tweaks and fixes

[dave]

On 03/03/2014 03:19 PM, Steve Borho wrote:
> On Mon, Mar 3, 2014 at 5:12 PM, dave <dtyx265 at gmail.com> wrote:
>> On 03/03/2014 02:51 PM, Tim Walker wrote:
>>> On 03 Mar 2014, at 23:27, dtyx265 at gmail.com wrote:
>>>
>>>> A few VUI tweaks and fixes.
>>> Maybe something slightly more descriptive would be useful?
>>>
>>> More importantly, can you please elaborate on exactly what tweaks and
>>> fixes you did for curious people like me?
>>>
>>> Cheers,
>>>
>>> Tim
>>> _______________________________________________
>>> x265-devel mailing list
>>> x265-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/x265-devel
>>
>> Tweaks:
>>
>> Renamed SubPicCpbParamsPresentFlag to SubPicHrdParamsPresentFlag.  There is
>> no h265 hrd field called SubPicCpbParamsPresentFlag, it was probably a typo
>> and should have been SubPicHrdParamsPresentFlag
>>
>>
>> Fixes:
>>
>> corrected --nal-hrd option
>> added --hrd option
>> corrected --subpichrd option
> Do these options actually work?  They seem to imply further SEI
> messages will follow in the bitstream and I'm not sure we will
> actually emit them.  I think we should hide/disable options which are
> not fully functional.
>
Yes, they work.  None of them directly relates to SEI messages but 
--subpichrd will cause the addition of other hrd fields that reflect the 
status of SEI messages.  Currently they are only set to default values 
which don't include the SEI messages but it's not clear if they are 
supposed to trigger the addition of SEI messages or simply reflect their 
status.