[x265] [PATCH] asm: added code for blockcopy_ss and cleaned up asm primitives of blockcopy

Steve Borho steve at borho.org
Thu Mar 6 21:45:59 CET 2014


On Thu, Mar 6, 2014 at 2:43 PM, Steve Borho <steve at borho.org> wrote:
> On Thu, Mar 6, 2014 at 8:26 AM,  <murugan at multicorewareinc.com> wrote:
>> # HG changeset patch
>> # User Murugan Vairavel <murugan at multicorewareinc.com>
>> # Date 1394104061 -19800
>> #      Thu Mar 06 16:37:41 2014 +0530
>> # Node ID 5cd0151094ba957f83e00d4a319c9e615f6c8587
>> # Parent  f2fe08b5472fb3b1b47beac2e04e68c783d98836
>> asm: added code for blockcopy_ss and cleaned up asm primitives of blockcopy
>
> HIGH_BIT_DEPTH builds fail on gcc

actually, all gcc / clang builds fail this way.  gcc's preprocessor
does not allow ## concatenation in this way.  Generally you fix this
problem by just removing the ## concatenators

>
> /Users/steve/repos/x265/source/common/x86/asm-primitives.cpp:991:9:
> error: pasting formed 'copy_ss[', an invalid preprocessing token
>
>         CHROMA_BLOCKCOPY(ss, _sse2);
>
>         ^
>
> /Users/steve/repos/x265/source/common/x86/asm-primitives.cpp:423:5:
> note: expanded from macro 'CHROMA_BLOCKCOPY'
>
>     SETUP_CHROMA_BLOCKCOPY(type, 2,  4,  cpu); \
>
>     ^
>
> /Users/steve/repos/x265/source/common/x86/asm-primitives.cpp:420:43:
> note: expanded from macro 'SETUP_CHROMA_BLOCKCOPY'
>
>     p.chroma[X265_CSP_I420].copy_ ## type ## [CHROMA_ ## W ## x ## H]
> = x265_blockcopy_ ## type ##_ ## W ## x ## H ## cpu;
>
> --
> Steve Borho



-- 
Steve Borho


More information about the x265-devel mailing list