[x265] [PATCH] primitives: added C primitives for upShift/downShift input pixels

Murugan Vairavel murugan at multicorewareinc.com
Thu Mar 13 05:41:04 CET 2014


I will correct it and send a new patch.


On Wed, Mar 12, 2014 at 6:04 PM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 3/12/2014 8:45 AM, Steve Borho wrote:
> >> > -            for (int c = 0; c < width; c++)
> >> > +            y += lumaWidth;
> >> > +            Y += lumaWidth;
> >> > +            v += chromaWidth;
> >> > +            V += chromaWidth;
> >> > +            u += chromaWidth;
> >> > +            U += chromaWidth;
> >
> > blech. the destination buffer has loads of padding (stride is much
> > wider than width), writing past the right edge is perfectly safe but
> > you do need to be careful about reading beyond the input stride.
>
> I'd just like to note that using one letter variables that differ only by
> case
> is *insane*, and renders the code unreadable.
>
> - Derek
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>



-- 
With Regards,

Murugan. V
+919659287478
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20140313/9f6e9fbe/attachment.html>


More information about the x265-devel mailing list